Tagged: patches Toggle Comment Threads | Keyboard Shortcuts

  • Juan Ramon 4:13 pm on May 9, 2012 Permalink | Reply
    Tags: patches   

    Hello everyone. I’ve made some changes and I would like to know what you think.

    • I think that the order of the subprojects in the project page it’s the other way around. You can see how it looks like and how I think it should look like. #199.
    • Remove all the references to translate via google. I see the post in WP Polyglots talking about the Translate Google API and I think that it’s a good idea to remove this functionality. But I would like to know what do you think about it. I’ve attached the patch to the original ticket #170.
     

    • Andrew Nacin 3:22 pm on May 11, 2012 Permalink | Reply

      I commented on #199.

      #170 looks good — will get to that soon. I have a feeling there might be a few more things we need to tear out, but it looks pretty thorough.

  • Zé 5:58 pm on October 18, 2011 Permalink | Reply
    Tags: patches,   

    Milan, I completely agree with this, but we’ll need more hands/eyes to test the patches on the code that has changed, quite a lot sometimes, since they were submitted. Any takers?

     

    • Carlos E. G. Barbosa 4:10 pm on October 21, 2011 Permalink | Reply

      I would like to take it, hence and while…
      What is the task?

    • Juan Ramon 2:41 pm on November 24, 2011 Permalink | Reply

      I’ve seen that most issues in the trac are very old. If we review them and upload patches to the trac or we test another patches, it will be merge to the core?

    • Peter 3:15 pm on January 17, 2012 Permalink | Reply

      As Juan asked, will reviewed patches be merged into the core? The reason for asking is the fact that you yourself have a trac ticket #164, that is on needs-review for 4 months now.
      Is there a development team who approves patches and merges them into the core? I know you can submit to the SVN as can Nikolay of course but who else?

      • Zé 3:21 pm on January 17, 2012 Permalink | Reply

        Right now, only Nikolay and myself (and Nacin) can commit, so, the question here is how to work out a way for patches to get in to core? I suggest (subjectively) that we do a thourough review and testing of the more pressing patches and commit those. The quality of code of individual contributors should then, over time, indicate candidates for core-committing privileges. Again, that’s just me, all suggestions are welcome.

        • Peter 4:58 pm on January 17, 2012 Permalink

          Sounds good. Do you with “we do a thorough review and testing” mean the 3 mentioned or will there be a review/testing team, or is it just anybody who can say Yes It Works :)
          I do suggest that you and Nikolay setup a roadmap with milestones and assign the tickets accordingly. That way it’s easier to pick up tickets and work on them.

          Maybe even set Trac up the way WordPress core is setup.

c
compose new post
j
next post/next comment
k
previous post/previous comment
r
reply
e
edit
o
show/hide comments
t
go to top
l
go to login
h
show/hide help
shift + esc
cancel
Follow

Get every new post delivered to your Inbox.

Join 160 other followers